From 3d430935cf85c0fd39804da32870b15cf3e3ba42 Mon Sep 17 00:00:00 2001 From: Assam Boudjelthia Date: Wed, 5 May 2021 21:31:16 +0300 Subject: [PATCH] Simplify setAndroidSdkVersion in qjnihelpers Change-Id: Ib4695ffa1443a0b393d152a51a811f4afb163100 Reviewed-by: Alex Blasche --- src/corelib/kernel/qjnihelpers.cpp | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/src/corelib/kernel/qjnihelpers.cpp b/src/corelib/kernel/qjnihelpers.cpp index 343a2f424ec..f847bc73809 100644 --- a/src/corelib/kernel/qjnihelpers.cpp +++ b/src/corelib/kernel/qjnihelpers.cpp @@ -289,21 +289,10 @@ void QtAndroidPrivate::handleResume() listeners.at(i)->handleResume(); } -static void setAndroidSdkVersion(JNIEnv *env) -{ - jclass androidVersionClass = env->FindClass("android/os/Build$VERSION"); - if (QJniEnvironment::checkAndClearExceptions(env)) - return; - - jfieldID androidSDKFieldID = env->GetStaticFieldID(androidVersionClass, "SDK_INT", "I"); - if (QJniEnvironment::checkAndClearExceptions(env)) - return; - - g_androidSdkVersion = env->GetStaticIntField(androidVersionClass, androidSDKFieldID); -} - jint QtAndroidPrivate::initJNI(JavaVM *vm, JNIEnv *env) { + g_javaVM = vm; + jclass jQtNative = env->FindClass("org/qtproject/qt/android/QtNative"); if (QJniEnvironment::checkAndClearExceptions(env)) @@ -344,7 +333,7 @@ jint QtAndroidPrivate::initJNI(JavaVM *vm, JNIEnv *env) if (QJniEnvironment::checkAndClearExceptions(env)) return JNI_ERR; - setAndroidSdkVersion(env); + g_androidSdkVersion = QJniObject::getStaticField("android/os/Build$VERSION", "SDK_INT"); g_jClassLoader = env->NewGlobalRef(classLoader); env->DeleteLocalRef(classLoader); @@ -356,7 +345,6 @@ jint QtAndroidPrivate::initJNI(JavaVM *vm, JNIEnv *env) g_jService = env->NewGlobalRef(service); env->DeleteLocalRef(service); } - g_javaVM = vm; static const JNINativeMethod methods[] = { {"runPendingCppRunnables", "()V", reinterpret_cast(runPendingCppRunnables)},