From 3be0f9e4ea663cd790746de5f82f7dac3a101090 Mon Sep 17 00:00:00 2001 From: Paul Wicking Date: Tue, 20 Aug 2024 13:13:30 +0200 Subject: [PATCH] Doc: Fix issues in print media type in offline style When generating HTML output, QDoc references CSS styles that control the visual appearance. For a standard build of Qt's documentation (a 'local' build, if you will), an "offline" style is the default. This style sheet is maintained in `qtbase.git`. This style is not particularly well maintained, as it is not the style in use for documentation published to `doc.qt.io`. As such, some issues where found as a side-effect of other work. In particular, an ill-placed background image in the `@media print` CSS instructions was found in the print dialogue from locally generated content. While validating the fix, it became clear that the `toc` CSS class was moved into an obstructing position in the same media type. Change the `@media print` definition such that: - The `toc` class is hidden entirely. Task-number: QTBUG-124162 Fixes: QTBUG-128205 Change-Id: Ic427036a698d7fc0e07e9190289e5d2c196885d9 Reviewed-by: Andreas Eliasson (cherry picked from commit dd669c84657c48c27318b246db83b82478d6951a) Reviewed-by: Qt Cherry-pick Bot --- doc/global/template/style/offline.css | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/doc/global/template/style/offline.css b/doc/global/template/style/offline.css index 6426109a497..1e5f3dd1e38 100644 --- a/doc/global/template/style/offline.css +++ b/doc/global/template/style/offline.css @@ -642,14 +642,7 @@ Content table @media print { .toc { - float: right; - clear: right; - padding-bottom: 10px; - padding-top: 50px; - width: 100%; - background-image: url(../images/bgrContent.png); - background-position: top; - background-repeat: no-repeat; + display: none; } }