From 3ad0f755f56eae4e8d94459f7cc17671e51e95da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Fri, 8 Jul 2022 11:48:51 +0200 Subject: [PATCH] cmake: Don't reference global data in qt_internal_get_title_case The only place the function was used was to generate the title case of a target, so the issue wasn't spotted until now. Pick-to: 6.2 6.3 6.4 Change-Id: Iee66ecea569e7411c6b5a5e5312cde910a48fa01 Reviewed-by: Alexandru Croitor --- cmake/QtAppHelpers.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/QtAppHelpers.cmake b/cmake/QtAppHelpers.cmake index 32614f492ff..e80f13cd173 100644 --- a/cmake/QtAppHelpers.cmake +++ b/cmake/QtAppHelpers.cmake @@ -75,7 +75,7 @@ function(qt_internal_get_title_case value out_var) endif() string(SUBSTRING "${value}" 0 1 first_char) string(TOUPPER "${first_char}" first_char_upper) - string(SUBSTRING "${target}" 1 -1 rest_of_value) + string(SUBSTRING "${value}" 1 -1 rest_of_value) set(title_value "${first_char_upper}${rest_of_value}") set(${out_var} "${title_value}" PARENT_SCOPE) endfunction()