From 3a863280dc7f1845bf3daa74fe235b1df9bc26ae Mon Sep 17 00:00:00 2001 From: Mark Brand Date: Wed, 15 Feb 2012 10:22:15 +0100 Subject: [PATCH] QSqlTableModel: avoid extra QMap lookup The consensus on #qt-labs seems to be that there is little or no point in checking with contains() before using value(), even if the map does not contain the key in most cases. Change-Id: I34740a91d5c3af65e20937a5ae3b4bab32406440 Reviewed-by: Robin Burchell --- src/sql/models/qsqltablemodel.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp index f30352e2fec..0cb7c3921b1 100644 --- a/src/sql/models/qsqltablemodel.cpp +++ b/src/sql/models/qsqltablemodel.cpp @@ -439,13 +439,11 @@ QVariant QSqlTableModel::headerData(int section, Qt::Orientation orientation, in { Q_D(const QSqlTableModel); if (orientation == Qt::Vertical && role == Qt::DisplayRole) { - if (d->cache.contains(section)) { - const QSqlTableModelPrivate::Op op = d->cache.value(section).op(); - if (op == QSqlTableModelPrivate::Insert) - return QLatin1String("*"); - else if (op == QSqlTableModelPrivate::Delete) - return QLatin1String("!"); - } + const QSqlTableModelPrivate::Op op = d->cache.value(section).op(); + if (op == QSqlTableModelPrivate::Insert) + return QLatin1String("*"); + else if (op == QSqlTableModelPrivate::Delete) + return QLatin1String("!"); } return QSqlQueryModel::headerData(section, orientation, role); }