1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MOC: don't create unnecessary QByteArray copies

Browse Source 
To avoid changing the ref count and the associated atomic operations.

Change-Id: I4195383bc15b36be564909bbdbc0abebc3b00787
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
Ahmad Samir 2025-04-13 19:11:04 +02:00 committed by Jukka Jokiniva
parent 05e59e37c8
commit 3a1f4f718d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/moc/generator.cpp
View File

@ -903,7 +903,7 @@ QMultiMap<QByteArray, int> Generator::automaticPropertyMetaTypesHelper()
QMultiMap<QByteArray, int> automaticPropertyMetaTypes;
for (int i = 0; i < int(cdef->propertyList.size()); ++i) {
const PropertyDef &p = cdef->propertyList.at(i);
const QByteArray propertyType = p.type;
const QByteArray &propertyType = p.type;
if (registerableMetaType(propertyType) && !isBuiltinType(propertyType))
automaticPropertyMetaTypes.insert(cxxTypeTag(p.typeTag) + propertyType, i);
}
@ -917,7 +917,7 @@ Generator::methodsWithAutomaticTypesHelper(const QList<FunctionDef> &methodList)
for (int i = 0; i < methodList.size(); ++i) {
const FunctionDef &f = methodList.at(i);
for (int j = 0; j < f.arguments.size(); ++j) {
const QByteArray argType = f.arguments.at(j).normalizedType;
const QByteArray &argType = f.arguments.at(j).normalizedType;
if (registerableMetaType(argType) && !isBuiltinType(argType))
methodsWithAutomaticTypes[i].insert(argType, j);
}