1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QSslSocket manual test: replace QList with const array

Browse Source 
"Never use a dynamically-sized container for statically-sized data."

Port the loop from Q_FOREACH (which can't deal with arrays) to ranged
for (which can).

Task-number: QTBUG-115839
Change-Id: Ib89d07fb751e3905a230ee5641e2e509e9415bed
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
(cherry picked from commit ba4b88d9d2f1dd03906f445c55f8959e0165505f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2023-08-08 07:37:03 +02:00 committed by Qt Cherry-pick Bot
parent 9cd6cb67eb
commit 367cc461c1
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/manual/qsslsocket/main.cpp
View File

@ -30,14 +30,15 @@ void tst_QSslSocket::nextProtocolNegotiation_data()
QTest::addColumn<QByteArray>("expectedProtocol"); QTest::addColumn<QByteArray>("expectedProtocol");
QTest::addColumn<QSslConfiguration::NextProtocolNegotiationStatus>("expectedStatus"); QTest::addColumn<QSslConfiguration::NextProtocolNegotiationStatus>("expectedStatus");
QList<QString> hosts = QList<QString>() const QString hosts[] = {
<< QStringLiteral("www.google.com") QStringLiteral("www.google.com"),
<< QStringLiteral("www.facebook.com") QStringLiteral("www.facebook.com"),
<< QStringLiteral("www.twitter.com") QStringLiteral("www.twitter.com"),
<< QStringLiteral("graph.facebook.com") QStringLiteral("graph.facebook.com"),
<< QStringLiteral("api.twitter.com"); QStringLiteral("api.twitter.com"),
};
foreach (QString host, hosts) { for (const QString &host : hosts) {
QByteArray tag = host.toLocal8Bit(); QByteArray tag = host.toLocal8Bit();
tag.append("-none"); tag.append("-none");
QTest::newRow(tag) QTest::newRow(tag)