1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add nodiscard attribute to QtMiscUtils functions

Browse Source 
Change-Id: I2039fcaafc478aaac45dce88b5d979a66a2f2424
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Ali Can Demiralp 2025-04-08 16:53:42 +02:00
parent 4076638022
commit 351800ace2
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/corelib/tools/qtools_p.h
View File

@ -24,12 +24,12 @@
QT_BEGIN_NAMESPACE QT_BEGIN_NAMESPACE
namespace QtMiscUtils { namespace QtMiscUtils {
constexpr inline char toHexUpper(char32_t value) noexcept [[nodiscard]] constexpr inline char toHexUpper(char32_t value) noexcept
{ {
return "0123456789ABCDEF"[value & 0xF]; return "0123456789ABCDEF"[value & 0xF];
} }
constexpr inline char toHexLower(char32_t value) noexcept [[nodiscard]] constexpr inline char toHexLower(char32_t value) noexcept
{ {
return "0123456789abcdef"[value & 0xF]; return "0123456789abcdef"[value & 0xF];
} }
@ -41,7 +41,7 @@ constexpr inline char toHexLower(char32_t value) noexcept
|| (c >= 'a' && c <= 'f'); || (c >= 'a' && c <= 'f');
} }
constexpr inline int fromHex(char32_t c) noexcept [[nodiscard]] constexpr inline int fromHex(char32_t c) noexcept
{ {
return ((c >= '0') && (c <= '9')) ? int(c - '0') : return ((c >= '0') && (c <= '9')) ? int(c - '0') :
((c >= 'A') && (c <= 'F')) ? int(c - 'A' + 10) : ((c >= 'A') && (c <= 'F')) ? int(c - 'A' + 10) :
@ -49,7 +49,7 @@ constexpr inline int fromHex(char32_t c) noexcept
/* otherwise */ -1; /* otherwise */ -1;
} }
constexpr inline char toOct(char32_t value) noexcept [[nodiscard]] constexpr inline char toOct(char32_t value) noexcept
{ {
return char('0' + (value & 0x7)); return char('0' + (value & 0x7));
} }
@ -59,7 +59,7 @@ constexpr inline char toOct(char32_t value) noexcept
return c >= '0' && c <= '7'; return c >= '0' && c <= '7';
} }
constexpr inline int fromOct(char32_t c) noexcept [[nodiscard]] constexpr inline int fromOct(char32_t c) noexcept
{ {
return isOctalDigit(c) ? int(c - '0') : -1; return isOctalDigit(c) ? int(c - '0') : -1;
} }
@ -69,44 +69,44 @@ constexpr inline int fromOct(char32_t c) noexcept
return c >= '0' && c <= '9'; return c >= '0' && c <= '9';
} }
constexpr inline bool isAsciiUpper(char32_t c) noexcept [[nodiscard]] constexpr inline bool isAsciiUpper(char32_t c) noexcept
{ {
return c >= 'A' && c <= 'Z'; return c >= 'A' && c <= 'Z';
} }
constexpr inline bool isAsciiLower(char32_t c) noexcept [[nodiscard]] constexpr inline bool isAsciiLower(char32_t c) noexcept
{ {
return c >= 'a' && c <= 'z'; return c >= 'a' && c <= 'z';
} }
constexpr inline bool isAsciiLetterOrNumber(char32_t c) noexcept [[nodiscard]] constexpr inline bool isAsciiLetterOrNumber(char32_t c) noexcept
{ {
return isAsciiDigit(c) || isAsciiLower(c) || isAsciiUpper(c); return isAsciiDigit(c) || isAsciiLower(c) || isAsciiUpper(c);
} }
constexpr inline char toAsciiLower(char ch) noexcept [[nodiscard]] constexpr inline char toAsciiLower(char ch) noexcept
{ {
return isAsciiUpper(ch) ? ch - 'A' + 'a' : ch; return isAsciiUpper(ch) ? ch - 'A' + 'a' : ch;
} }
constexpr inline char toAsciiUpper(char ch) noexcept [[nodiscard]] constexpr inline char toAsciiUpper(char ch) noexcept
{ {
return isAsciiLower(ch) ? ch - 'a' + 'A' : ch; return isAsciiLower(ch) ? ch - 'a' + 'A' : ch;
} }
constexpr inline int caseCompareAscii(char lhs, char rhs) noexcept [[nodiscard]] constexpr inline int caseCompareAscii(char lhs, char rhs) noexcept
{ {
const char lhsLower = QtMiscUtils::toAsciiLower(lhs); const char lhsLower = QtMiscUtils::toAsciiLower(lhs);
const char rhsLower = QtMiscUtils::toAsciiLower(rhs); const char rhsLower = QtMiscUtils::toAsciiLower(rhs);
return int(uchar(lhsLower)) - int(uchar(rhsLower)); return int(uchar(lhsLower)) - int(uchar(rhsLower));
} }
constexpr inline int isAsciiPrintable(char32_t ch) noexcept [[nodiscard]] constexpr inline int isAsciiPrintable(char32_t ch) noexcept
{ {
return ch >= ' ' && ch < 0x7f; return ch >= ' ' && ch < 0x7f;
} }
constexpr inline int qt_lencmp(qsizetype lhs, qsizetype rhs) noexcept [[nodiscard]] constexpr inline int qt_lencmp(qsizetype lhs, qsizetype rhs) noexcept
{ {
return lhs == rhs ? 0 : return lhs == rhs ? 0 :
lhs > rhs ? 1 : lhs > rhs ? 1 :