1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QNetworkInformation: Address API review feedback

Browse Source 
Added missing NOTIFY for Q_PROPERTY.
Switched one Q_ENUM to Q_FLAG.
Declared missing operators for QFlag.

Change-Id: I8e6756838e44e205844a34c95f436df6b51a862f
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 0d4fb41e8c00263a0d385b70cc066776cbf6cc37)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Mårten Nordheim 2021-02-17 13:59:29 +01:00 committed by Qt Cherry-pick Bot
parent 8fa8f4dab0
commit 3470241161
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/network/kernel/qnetworkinformation.h
View File

@ -53,7 +53,7 @@ class Q_NETWORK_EXPORT QNetworkInformation : public QObject
{ {
Q_OBJECT Q_OBJECT
Q_DECLARE_PRIVATE(QNetworkInformation) Q_DECLARE_PRIVATE(QNetworkInformation)
Q_PROPERTY(Reachability reachability READ reachability) Q_PROPERTY(Reachability reachability READ reachability NOTIFY reachabilityChanged)
public: public:
enum class Reachability { enum class Reachability {
Unknown, Unknown,
@ -67,8 +67,8 @@ public:
enum class Feature { enum class Feature {
Reachability = 0x1, Reachability = 0x1,
}; };
Q_ENUM(Feature)
Q_DECLARE_FLAGS(Features, Feature) Q_DECLARE_FLAGS(Features, Feature)
Q_FLAG(Features)
~QNetworkInformation() override; ~QNetworkInformation() override;
@ -93,6 +93,8 @@ private:
Q_DISABLE_COPY_MOVE(QNetworkInformation) Q_DISABLE_COPY_MOVE(QNetworkInformation)
}; };
Q_DECLARE_OPERATORS_FOR_FLAGS(QNetworkInformation::Features)
QT_END_NAMESPACE QT_END_NAMESPACE
#endif #endif