From 3305eb10da541be036e6fa77fb2b3a80bfae7cda Mon Sep 17 00:00:00 2001 From: Assam Boudjelthia Date: Thu, 2 Jan 2025 17:36:36 +0200 Subject: [PATCH] Android: don't call onSurfaceChange() native method with every change We don't need to re-assign the surface each time it's changed, instead the assignment needs to be done only when creating or destroying the surface. Task-number: QTBUG-132721 Change-Id: I72c8c81a692b9e739af0e0a7b0f934b69a9a0fa8 Reviewed-by: Petri Virkkunen --- .../jar/src/org/qtproject/qt/android/QtSurface.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/android/jar/src/org/qtproject/qt/android/QtSurface.java b/src/android/jar/src/org/qtproject/qt/android/QtSurface.java index 46a668d84d3..c65c57c7113 100644 --- a/src/android/jar/src/org/qtproject/qt/android/QtSurface.java +++ b/src/android/jar/src/org/qtproject/qt/android/QtSurface.java @@ -32,16 +32,13 @@ class QtSurface extends SurfaceView implements SurfaceHolder.Callback @Override public void surfaceCreated(SurfaceHolder holder) { + if (m_surfaceCallback != null) + m_surfaceCallback.onSurfaceChanged(holder.getSurface()); } @Override public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) - { - if (width < 1 || height < 1) - return; - if (m_surfaceCallback != null) - m_surfaceCallback.onSurfaceChanged(holder.getSurface()); - } + { } @Override public void surfaceDestroyed(SurfaceHolder holder)