From 3247f2ece90ab73dcb3d927e3683137890a916a4 Mon Sep 17 00:00:00 2001 From: David Faure Date: Sat, 5 May 2012 22:37:52 +0200 Subject: [PATCH] Fix -Wlogical-op warning in qtestmouse.h error: logical 'or' of collectively exhaustive tests is always true [-Werror=logical-op] Indeed these asserts do not test anything, given that MouseButtonMask is 0xffffffff Change-Id: I33cf59d3e77d9c644fc307de36f4e0ab1bea80f8 Reviewed-by: Thiago Macieira --- src/testlib/qtestmouse.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/testlib/qtestmouse.h b/src/testlib/qtestmouse.h index 3dd39f96bd8..4ee31ff47f6 100644 --- a/src/testlib/qtestmouse.h +++ b/src/testlib/qtestmouse.h @@ -100,7 +100,6 @@ namespace QTest mouseEvent(MouseRelease, window, button, stateKey, pos); return; } - QTEST_ASSERT(button == Qt::NoButton || button & Qt::MouseButtonMask); QTEST_ASSERT(stateKey == 0 || stateKey & Qt::KeyboardModifierMask); stateKey &= static_cast(Qt::KeyboardModifierMask); @@ -172,7 +171,6 @@ namespace QTest return; } - QTEST_ASSERT(button == Qt::NoButton || button & Qt::MouseButtonMask); QTEST_ASSERT(stateKey == 0 || stateKey & Qt::KeyboardModifierMask); stateKey &= static_cast(Qt::KeyboardModifierMask);