1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Torrent example: Fix use-after-free crash

Browse Source 
The crash would sometimes happen shortly after removing a torrent
since the RateController would still try to use it even though
it had been deallocated.

Pick-to: 6.5
Task-number: QTBUG-110622
Change-Id: Icad1531ea58560a3a3157a3ed8c0e6b283573196
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Reviewed-by: Konrad Kujawa <konrad.kujawa@qt.io>
This commit is contained in:
Mårten Nordheim 2023-02-20 14:50:56 +01:00
parent f3de92cdad
commit 32098963f2
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/network/torrent/torrentclient.cpp
View File

@ -208,6 +208,10 @@ TorrentClient::TorrentClient(QObject *parent)
TorrentClient::~TorrentClient() TorrentClient::~TorrentClient()
{ {
auto rateController = RateController::instance();
const auto childSockets = findChildren<PeerWireClient *>(Qt::FindDirectChildrenOnly);
for (PeerWireClient *socket : childSockets)
rateController->removeSocket(socket);
qDeleteAll(d->peers); qDeleteAll(d->peers);
qDeleteAll(d->pendingPieces); qDeleteAll(d->pendingPieces);
delete d; delete d;