1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QProcess::startDetached/Unix: fix the resetting of SIGPIPE

Browse Source 
This should have been SIG_DFL, as we're about to execute a child
process. It's the child's responsibility to ignore SIGPIPE if it wants
to, or get killed by it when it writes to an pipe with no readers.

Qt itself does this for its own purposes (see qt_ignore_sigpipe() [until
I can get some time to teach Linux about O_NOSIGPIPE]). Therefore, we
ought to reset what we've done.

Change-Id: Ic90d8429a0eb4837971dfffd166585a686790dde
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
(cherry picked from commit f4e3b073b3d2a50133d734dd604bff21f061a3e6)
This commit is contained in:
Thiago Macieira 2021-02-18 10:54:58 -08:00
parent bcc80f4e21
commit 31849db9c6
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/corelib/io/qprocess_unix.cpp
View File

@ -911,11 +911,7 @@ bool QProcessPrivate::startDetached(qint64 *pid)
pid_t childPid = fork();
if (childPid == 0) {
struct sigaction noaction;
memset(&noaction, 0, sizeof(noaction));
noaction.sa_handler = SIG_IGN;
::sigaction(SIGPIPE, &noaction, nullptr);
::signal(SIGPIPE, SIG_DFL); // reset the signal that we ignored
::setsid();
qt_safe_close(startedPipe[0]);