From 2ed35fe88978112834fbf6c147e76b35ec7cb14b Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Sat, 18 Jan 2025 08:49:28 -0800 Subject: [PATCH] tst_QMessageLogger: disable Android once and for all The messages said "This test crashes on Android" bu tit appears the problem is not a crash, but that the executable can't be executed. The file appears to be present and yet execve() is producing ENOENT (No such file or directory). That probably means it's the interpreter stored in the ELF header's dynamic section that is not found. Fixing that is SEP[1]. [1] https://en.wikipedia.org/wiki/Somebody_else%27s_problem Change-Id: I3025825c5e00f47a5a40fffd53c47131db3676dc Reviewed-by: Assam Boudjelthia (cherry picked from commit 40ad963e1a22dbf3eea96f6a17bf6cbb28294649) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/corelib/global/qlogging/tst_qlogging.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/auto/corelib/global/qlogging/tst_qlogging.cpp b/tests/auto/corelib/global/qlogging/tst_qlogging.cpp index c8cd60dcdaa..24d994784ce 100644 --- a/tests/auto/corelib/global/qlogging/tst_qlogging.cpp +++ b/tests/auto/corelib/global/qlogging/tst_qlogging.cpp @@ -838,7 +838,7 @@ void tst_qmessagehandler::qMessagePattern() QSKIP("This test requires QProcess support"); #else #ifdef Q_OS_ANDROID - QSKIP("This test crashes on Android"); + QSKIP("This test is disabled on Android"); #endif QFETCH(QString, pattern); QFETCH(bool, valid); @@ -884,7 +884,7 @@ void tst_qmessagehandler::setMessagePattern() QSKIP("This test requires QProcess support"); #else #ifdef Q_OS_ANDROID - QSKIP("This test crashes on Android"); + QSKIP("This test is disabled on Android"); #endif // @@ -980,8 +980,8 @@ void tst_qmessagehandler::formatLogMessage() QString tst_qmessagehandler::backtraceHelperPath() { #ifdef Q_OS_ANDROID - QString appExe(QCoreApplication::applicationDirPath() - + QLatin1String("/lib" BACKTRACE_HELPER_NAME ".so")); + qFatal("Launching the helper (which does exist) produces 'No such file or directory'."); + QString appExe; #else QString appExe(QCoreApplication::applicationDirPath() + QLatin1String("/" BACKTRACE_HELPER_NAME));