From 2e24ee02af30821200876bcc0c308ee844155aec Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Tue, 20 Jul 2021 15:55:41 +0200 Subject: [PATCH] Don't slow down a QMap benchmark by growing a megabyte-long string Change a += to simple assignment where it's string arithmetic (a hundred thousand concatenations of "Hello World" add up to more than a megabyte, in an incremental growth that's going to dominate the QMap operations we were meant to be benchmarking) and the only reason for it is to avoid an unused result warning. Accumulating int values is harmless, but strings are another story ! Pick-to: 6.1 6.2 Task-number: QTBUG-91713 Change-Id: Ib0dc131b0cc75fea23998afc0300e8cb60076c7e Reviewed-by: Andrei Golubev --- tests/benchmarks/corelib/tools/qmap/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/benchmarks/corelib/tools/qmap/main.cpp b/tests/benchmarks/corelib/tools/qmap/main.cpp index 50cc853df6f..61b00b8a0df 100644 --- a/tests/benchmarks/corelib/tools/qmap/main.cpp +++ b/tests/benchmarks/corelib/tools/qmap/main.cpp @@ -156,7 +156,7 @@ void tst_QMap::lookup_int_string() QBENCHMARK { for (int i = 0; i < 100000; ++i) - str += map.value(i); + str = map.value(i); } }