From 2d035d50c8687a22869f1bb66fe528783414a5b5 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 28 Nov 2022 14:49:03 +0100 Subject: [PATCH] tst_QStringApiSymmetry: fix a typo and deal with the fallout Turns out we don't support QStringView/QUtf8StringView comparison, and the only reason the corresponding test succeeded was because it contained a typo (QStringView instead of QUtf8StringView). Fix the typo and disable the now-failing test. Change-Id: I2210a247aac66743851e53578172a563ee1e96f7 Reviewed-by: Thiago Macieira (cherry picked from commit 92e913a5414ea3a7fb002a139251bb8ae53c467c) Reviewed-by: Qt Cherry-pick Bot --- .../text/qstringapisymmetry/tst_qstringapisymmetry.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/auto/corelib/text/qstringapisymmetry/tst_qstringapisymmetry.cpp b/tests/auto/corelib/text/qstringapisymmetry/tst_qstringapisymmetry.cpp index 08854e91b29..cf406293e49 100644 --- a/tests/auto/corelib/text/qstringapisymmetry/tst_qstringapisymmetry.cpp +++ b/tests/auto/corelib/text/qstringapisymmetry/tst_qstringapisymmetry.cpp @@ -227,8 +227,10 @@ private Q_SLOTS: void compare_QStringView_QString() { compare_impl(); } void compare_QStringView_QStringView_data() { compare_data(); } void compare_QStringView_QStringView() { compare_impl(); } +#ifdef NOT_YET_IMPLEMENTED void compare_QStringView_QUtf8StringView_data() { compare_data(); } - void compare_QStringView_QUtf8StringView() { compare_impl(); } + void compare_QStringView_QUtf8StringView() { compare_impl(); } +#endif void compare_QStringView_QLatin1String_data() { compare_data(); } void compare_QStringView_QLatin1String() { compare_impl(); } #ifdef NOT_YET_IMPLMENTED