1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Q(Read|Write)Locker: mark ctors [[nodiscard]]

Browse Source 
They're RAII classes, and RAII class' constructors should be marked
[[nodiscard]].

Task-number: QTBUG-104164
Change-Id: I9b91c18e67e99bf84abdd12236a18a8c4ec39620
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 6dba28419bf6e8ee401708650bb60347bb79d978)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2023-06-13 09:34:12 +02:00 committed by Qt Cherry-pick Bot
parent d082bf07a9
commit 2c07d59092
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/corelib/thread/qreadwritelock.h
View File

@ -92,6 +92,7 @@ bool QReadWriteLock::tryLockForWrite(int timeout)
class QT6_ONLY(Q_CORE_EXPORT) QReadLocker
{
public:
Q_NODISCARD_CTOR
inline QReadLocker(QReadWriteLock *readWriteLock);
inline ~QReadLocker()
@ -136,6 +137,7 @@ inline QReadLocker::QReadLocker(QReadWriteLock *areadWriteLock)
class QT6_ONLY(Q_CORE_EXPORT) QWriteLocker
{
public:
Q_NODISCARD_CTOR
inline QWriteLocker(QReadWriteLock *readWriteLock);
inline ~QWriteLocker()
@ -210,6 +212,7 @@ private:
class QT6_ONLY(Q_CORE_EXPORT) QReadLocker
{
public:
Q_NODISCARD_CTOR
inline explicit QReadLocker(QReadWriteLock *) noexcept { }
inline ~QReadLocker() noexcept { }
@ -224,6 +227,7 @@ private:
class QT6_ONLY(Q_CORE_EXPORT) QWriteLocker
{
public:
Q_NODISCARD_CTOR
inline explicit QWriteLocker(QReadWriteLock *) noexcept { }
inline ~QWriteLocker() noexcept { }