From 299000fa422b7a19f7eafde79520b96ab8376308 Mon Sep 17 00:00:00 2001 From: Nic Zonta Date: Tue, 3 Jun 2025 15:39:10 +0200 Subject: [PATCH] make all convenience functions in QFileDialog open modal dialogs most convenience functions in qfiledialog.cpp (e.g. getSaveFileUrl, getOpenFileUrl) open modal dialogs, with the exception of getOpenFileContent and saveFileContent. This makes every function consistently open modal dialogs Fixes: QTBUG-137329 Change-Id: I48952144ed15596b9acba3230c63cece613fb045 Reviewed-by: David Faure Reviewed-by: Axel Spoerl (cherry picked from commit 25fdc044f58d426c3056409e2883becdc3cf0bd1) Reviewed-by: Qt Cherry-pick Bot (cherry picked from commit e7a9bb77fe8b0717491480dc2ca976ec3ce9f633) --- src/widgets/dialogs/qfiledialog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/widgets/dialogs/qfiledialog.cpp b/src/widgets/dialogs/qfiledialog.cpp index 00a6193a82c..fee57003943 100644 --- a/src/widgets/dialogs/qfiledialog.cpp +++ b/src/widgets/dialogs/qfiledialog.cpp @@ -2333,7 +2333,7 @@ void QFileDialog::getOpenFileContent(const QString &nameFilter, const std::funct }; connect(dialog, &QFileDialog::fileSelected, dialog, fileSelected); - dialog->show(); + dialog->open(); #endif } @@ -2376,7 +2376,7 @@ void QFileDialog::saveFileContent(const QByteArray &fileContent, const QString & connect(dialog, &QFileDialog::fileSelected, dialog, fileSelected); dialog->setAttribute(Qt::WA_DeleteOnClose); - dialog->show(); + dialog->open(); #endif }