1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QTest::qExtractTestData(): Set permissions of extracted files.

Browse Source 
Currently, the files are extracted with read-only permissions.
If the data are extracted under a temporary directory, this prevents
it from being deleted, causing a leak and test failures (for example,
tst_qfileinfo).

Change-Id: Idc85f31265af234446ed21d736e9a2b9866dc62d
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
This commit is contained in:
Friedemann Kleint 2015-06-08 14:52:40 +02:00
parent 861cbef49f
commit 25fb41a58c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/testlib/qtestcase.cpp
View File

@ -2839,6 +2839,10 @@ QString QTest::qExtractTestData(const QString &dirName)
qWarning("Failed to copy '%s'.", qPrintable(fileInfo.filePath())); qWarning("Failed to copy '%s'.", qPrintable(fileInfo.filePath()));
return QString(); return QString();
} }
if (!QFile::setPermissions(destination, QFile::ReadUser | QFile::WriteUser | QFile::ReadGroup)) {
qWarning("Failed to set permissions on '%s'.", qPrintable(destination));
return QString();
}
} }
} }