1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QLocale: remove WhiteSpacesAllowed mode from qt_asciiToDouble()

Browse Source 
It's no longer used. It was used by QByteArray{,View}::toDouble() but
that caused an all-space string to be considered a valid conversion. Now
that those functions do the trimming themselves, we don't need this
mode.

Change-Id: I2c24d3011fd7969bcc92fffd802a5d78ca28c157
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
(cherry picked from commit 7838a57d2937070bb1a83122491f25b2b396553b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Thiago Macieira 2025-05-20 11:22:59 -07:00 committed by Qt Cherry-pick Bot
parent 4e785f1da5
commit 25d1dfcd49
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/corelib/text/qlocale_tools.cpp
View File

@ -301,9 +301,6 @@ QSimpleParsedNumber<double> qt_asciiToDouble(const char *num, qsizetype numLen,
int conv_flags = double_conversion::StringToDoubleConverter::NO_FLAGS;
if (strayCharMode == TrailingJunkAllowed) {
conv_flags = double_conversion::StringToDoubleConverter::ALLOW_TRAILING_JUNK;
} else if (strayCharMode == WhitespacesAllowed) {
conv_flags = double_conversion::StringToDoubleConverter::ALLOW_LEADING_SPACES
| double_conversion::StringToDoubleConverter::ALLOW_TRAILING_SPACES;
}
double_conversion::StringToDoubleConverter conv(conv_flags, 0.0, qt_qnan(), nullptr, nullptr);
if (int(numLen) != numLen) {

1
src/corelib/text/qlocale_tools_p.h
View File

@ -36,7 +36,6 @@ using qinternaluint128 = std::_Unsigned128;
enum StrayCharacterMode {
TrailingJunkProhibited,
TrailingJunkAllowed,
WhitespacesAllowed
};
// API note: this function can't process a number with more than 2.1 billion digits