From 259dc8cbe50af7fd48e6ff3e0a1880c26872620a Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 16 Jun 2021 10:29:01 +0200 Subject: [PATCH] QTextStream: fix a dead write Found by Clazy. Change-Id: Iabe4fb23f63ea8df2142dc66cd16b04526b628c2 Reviewed-by: Edward Welbourne --- src/corelib/serialization/qtextstream.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/corelib/serialization/qtextstream.cpp b/src/corelib/serialization/qtextstream.cpp index 392a6bfeaa9..50bb63465fe 100644 --- a/src/corelib/serialization/qtextstream.cpp +++ b/src/corelib/serialization/qtextstream.cpp @@ -560,7 +560,6 @@ bool QTextStreamPrivate::scan(const QChar **ptr, int *length, int maxlen, TokenD int startOffset = device ? readBufferOffset : stringOffset; QChar lastChar; - bool canStillReadFromDevice = true; do { int endOffset; const QChar *chPtr; @@ -602,7 +601,7 @@ bool QTextStreamPrivate::scan(const QChar **ptr, int *length, int maxlen, TokenD } } while (!foundToken && (!maxlen || totalSize < maxlen) - && (device && (canStillReadFromDevice = fillReadBuffer()))); + && device && fillReadBuffer()); if (totalSize == 0) { #if defined (QTEXTSTREAM_DEBUG)