1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qmake: Avoid comparison of values with different enumeration types

Browse Source 
A switch statement using enumeration type midlErrorCheckOption as
condition had an enumeration value from type midlStructMemberAlignOption
as a case label. This had only coincidentally the intended effect, since
the intended value (midlErrorCheckOption::midlEnableCustom) and the
actually used one
(midlStructMemberAlignOption::midlStructMemberAlignOption) have both
the value 0.

Change-Id: I73b337f23e733a1a6fb80517e29365e01838238a
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
This commit is contained in:
Alessandro Portale 2018-08-02 23:11:02 +02:00
parent d25d11e6e2
commit 24115f5a9c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qmake/generators/win32/msbuild_objectmodel.cpp
View File

@ -1201,7 +1201,7 @@ static inline QString toString(midlCharOption option)
static inline QString toString(midlErrorCheckOption option) static inline QString toString(midlErrorCheckOption option)
{ {
switch (option) { switch (option) {
case midlAlignNotSet: case midlEnableCustom:
break; break;
case midlDisableAll: case midlDisableAll:
return "None"; return "None";