1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Turn itemActivated() slot of RSS listing example into a lambda

Browse Source 
It needs nothing but the parameter it is passed and has no material
interaction with the rest of the RSSListing class, so there's no point
devoting a slot to it, much less a public one.

Task-number: QTBUG-111228
Change-Id: I46d572982197550801c6fa4425453fc670c6f2f1
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit e7b1bc659087ce28fbc40b3ebe79cc10462994fa)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Edward Welbourne 2023-05-05 17:53:15 +02:00 committed by Qt Cherry-pick Bot
parent d2d63ed679
commit 22466d6685
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
examples/corelib/serialization/rsslisting/rsslisting.cpp
View File

@ -46,7 +46,8 @@ RSSListing::RSSListing(const QString &url, QWidget *parent)
treeWidget = new QTreeWidget(this); treeWidget = new QTreeWidget(this);
connect(treeWidget, &QTreeWidget::itemActivated, connect(treeWidget, &QTreeWidget::itemActivated,
this, &RSSListing::itemActivated); // Open the link in the browser:
this, [](QTreeWidgetItem *item) { QDesktopServices::openUrl(QUrl(item->text(1))); });
QStringList headerLabels; QStringList headerLabels;
headerLabels << tr("Title") << tr("Link"); headerLabels << tr("Title") << tr("Link");
treeWidget->setHeaderLabels(headerLabels); treeWidget->setHeaderLabels(headerLabels);
@ -179,14 +180,6 @@ void RSSListing::parseXml()
qWarning() << "XML ERROR:" << xml.lineNumber() << ": " << xml.errorString(); qWarning() << "XML ERROR:" << xml.lineNumber() << ": " << xml.errorString();
} }
/*
Open the link in the browser
*/
void RSSListing::itemActivated(QTreeWidgetItem *item)
{
QDesktopServices::openUrl(QUrl(item->text(1)));
}
void RSSListing::error(QNetworkReply::NetworkError) void RSSListing::error(QNetworkReply::NetworkError)
{ {
qWarning("error retrieving RSS feed"); qWarning("error retrieving RSS feed");

1
examples/corelib/serialization/rsslisting/rsslisting.h
View File

@ -28,7 +28,6 @@ public slots:
void finished(QNetworkReply *reply); void finished(QNetworkReply *reply);
void readyRead(); void readyRead();
void metaDataChanged(); void metaDataChanged();
void itemActivated(QTreeWidgetItem *item);
void error(QNetworkReply::NetworkError); void error(QNetworkReply::NetworkError);
private: private: