1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a couple of noexcept where we can't throw exceptions

Browse Source 
Change-Id: I4fd40ea9f6258827cce8bf94ac4fd3067bdafc19
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
This commit is contained in:
Lars Knoll 2020-11-09 14:33:39 +01:00
parent fed055790a
commit 21116d6017
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/corelib/tools/qarraydataops.h
View File

@ -232,7 +232,7 @@ protected:
public: public:
typedef typename QArrayDataPointer<T>::parameter_type parameter_type; typedef typename QArrayDataPointer<T>::parameter_type parameter_type;
void appendInitialize(qsizetype newSize) void appendInitialize(qsizetype newSize) noexcept
{ {
Q_ASSERT(this->isMutable()); Q_ASSERT(this->isMutable());
Q_ASSERT(!this->isShared()); Q_ASSERT(!this->isShared());
@ -243,7 +243,7 @@ public:
this->size = qsizetype(newSize); this->size = qsizetype(newSize);
} }
void moveAppend(T *b, T *e) void moveAppend(T *b, T *e) noexcept
{ {
Q_ASSERT(b < e); Q_ASSERT(b < e);
Q_ASSERT((e - b) <= this->freeSpaceAtEnd()); Q_ASSERT((e - b) <= this->freeSpaceAtEnd());
@ -252,7 +252,7 @@ public:
this->size += (e - b); this->size += (e - b);
} }
void truncate(size_t newSize) void truncate(size_t newSize) noexcept
{ {
Q_ASSERT(this->isMutable()); Q_ASSERT(this->isMutable());
Q_ASSERT(!this->isShared()); Q_ASSERT(!this->isShared());
@ -261,7 +261,7 @@ public:
this->size = qsizetype(newSize); this->size = qsizetype(newSize);
} }
void destroyAll() // Call from destructors, ONLY! void destroyAll() noexcept // Call from destructors, ONLY!
{ {
Q_ASSERT(this->d); Q_ASSERT(this->d);
Q_ASSERT(this->d->ref_.loadRelaxed() == 0); Q_ASSERT(this->d->ref_.loadRelaxed() == 0);
@ -270,7 +270,7 @@ public:
// exception safe; size not updated. // exception safe; size not updated.
} }
void insert(GrowsForwardTag, T *where, const T *b, const T *e) void insert(GrowsForwardTag, T *where, const T *b, const T *e) noexcept
{ {
Q_ASSERT(this->isMutable() || (b == e && where == this->end())); Q_ASSERT(this->isMutable() || (b == e && where == this->end()));
Q_ASSERT(!this->isShared() || (b == e && where == this->end())); Q_ASSERT(!this->isShared() || (b == e && where == this->end()));
@ -286,7 +286,7 @@ public:
this->size += (e - b); this->size += (e - b);
} }
void insert(GrowsBackwardsTag, T *where, const T *b, const T *e) void insert(GrowsBackwardsTag, T *where, const T *b, const T *e) noexcept
{ {
Q_ASSERT(this->isMutable() || (b == e && where == this->end())); Q_ASSERT(this->isMutable() || (b == e && where == this->end()));
Q_ASSERT(!this->isShared() || (b == e && where == this->end())); Q_ASSERT(!this->isShared() || (b == e && where == this->end()));
@ -305,7 +305,7 @@ public:
this->size += (e - b); this->size += (e - b);
} }
void insert(GrowsForwardTag, T *where, size_t n, parameter_type t) void insert(GrowsForwardTag, T *where, size_t n, parameter_type t) noexcept
{ {
Q_ASSERT(!this->isShared()); Q_ASSERT(!this->isShared());
Q_ASSERT(n); Q_ASSERT(n);
@ -320,7 +320,7 @@ public:
*where++ = t; *where++ = t;
} }
void insert(GrowsBackwardsTag, T *where, size_t n, parameter_type t) void insert(GrowsBackwardsTag, T *where, size_t n, parameter_type t) noexcept
{ {
Q_ASSERT(!this->isShared()); Q_ASSERT(!this->isShared());
Q_ASSERT(n); Q_ASSERT(n);
@ -382,7 +382,7 @@ public:
++this->size; ++this->size;
} }
void erase(GrowsForwardTag, T *b, T *e) void erase(GrowsForwardTag, T *b, T *e) noexcept
{ {
Q_ASSERT(this->isMutable()); Q_ASSERT(this->isMutable());
Q_ASSERT(b < e); Q_ASSERT(b < e);
@ -394,7 +394,7 @@ public:
this->size -= (e - b); this->size -= (e - b);
} }
void erase(GrowsBackwardsTag, T *b, T *e) void erase(GrowsBackwardsTag, T *b, T *e) noexcept
{ {
Q_ASSERT(this->isMutable()); Q_ASSERT(this->isMutable());
Q_ASSERT(b < e); Q_ASSERT(b < e);
@ -408,20 +408,20 @@ public:
this->size -= (e - b); this->size -= (e - b);
} }
void eraseFirst() void eraseFirst() noexcept
{ {
Q_ASSERT(this->size); Q_ASSERT(this->size);
++this->ptr; ++this->ptr;
--this->size; --this->size;
} }
void eraseLast() void eraseLast() noexcept
{ {
Q_ASSERT(this->size); Q_ASSERT(this->size);
--this->size; --this->size;
} }
void assign(T *b, T *e, parameter_type t) void assign(T *b, T *e, parameter_type t) noexcept
{ {
Q_ASSERT(b <= e); Q_ASSERT(b <= e);
Q_ASSERT(b >= this->begin() && e <= this->end()); Q_ASSERT(b >= this->begin() && e <= this->end());