From 210e036488e109065d522cbb09c54094227ae9a8 Mon Sep 17 00:00:00 2001 From: Alexey Edelev Date: Thu, 24 Nov 2022 12:28:34 +0100 Subject: [PATCH] Add INTERFACE_LIBRARIES to dependencies of repo targets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Building repo targets may be incomplete as we skip adding INTERFACE_LIBRARIES as dependencies. This leads to the missing artifacts belonging to HEADER_MODULES. It seems reasonable and safe to include INTERFACE_LIBRARIES in the list of dependencies of the repo targets. Task-number: QTBUG-108815 Change-Id: I83f44018f42dcf2fb1e3299461e17ef53e79c2e5 Reviewed-by: Jörg Bornemann (cherry picked from commit ada76ac8b6ef6f4e8e6b60569c3d424aab335c3a) Reviewed-by: Qt Cherry-pick Bot --- cmake/QtBuildInternals/QtBuildInternalsConfig.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/QtBuildInternals/QtBuildInternalsConfig.cmake b/cmake/QtBuildInternals/QtBuildInternalsConfig.cmake index 9731eda061d..f51e4d6ab54 100644 --- a/cmake/QtBuildInternals/QtBuildInternalsConfig.cmake +++ b/cmake/QtBuildInternals/QtBuildInternalsConfig.cmake @@ -255,7 +255,7 @@ macro(qt_build_internals_get_repo_targets subdir) if(_targets) foreach(_target IN LISTS _targets) get_target_property(_type ${_target} TYPE) - if(NOT (${_type} STREQUAL "UTILITY" OR ${_type} STREQUAL "INTERFACE")) + if(NOT ${_type} STREQUAL "UTILITY") list(APPEND qt_repo_targets "${_target}") endif() endforeach()