From 1f72315adcc2726a6621069ddb1bbff026b2225a Mon Sep 17 00:00:00 2001 From: Mate Barany Date: Tue, 16 Jul 2024 16:14:17 +0200 Subject: [PATCH] Pass QNetworkRequest::Priority by value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It is a small and trivially copyable type. Found by an Axivion scan. Task-number: QTBUG-125026 Pick-to: 6.7 6.5 Change-Id: I7990d07a7062472108ab3fff8a135f1917c4f7c7 Reviewed-by: Marc Mutz Reviewed-by: MÃ¥rten Nordheim (cherry picked from commit 8448292074e72095ed177d77910abe47a24f318c) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qnetworkreplyhttpimpl.cpp | 2 +- src/network/access/qnetworkreplyhttpimpl_p.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/access/qnetworkreplyhttpimpl.cpp b/src/network/access/qnetworkreplyhttpimpl.cpp index 89458825e95..9af7f7cda39 100644 --- a/src/network/access/qnetworkreplyhttpimpl.cpp +++ b/src/network/access/qnetworkreplyhttpimpl.cpp @@ -612,7 +612,7 @@ bool QNetworkReplyHttpImplPrivate::loadFromCacheIfAllowed(QHttpNetworkRequest &h return sendCacheContents(metaData); } -QHttpNetworkRequest::Priority QNetworkReplyHttpImplPrivate::convert(const QNetworkRequest::Priority& prio) +QHttpNetworkRequest::Priority QNetworkReplyHttpImplPrivate::convert(QNetworkRequest::Priority prio) { switch (prio) { case QNetworkRequest::LowPriority: diff --git a/src/network/access/qnetworkreplyhttpimpl_p.h b/src/network/access/qnetworkreplyhttpimpl_p.h index e00c43bdb37..a88185fe0cc 100644 --- a/src/network/access/qnetworkreplyhttpimpl_p.h +++ b/src/network/access/qnetworkreplyhttpimpl_p.h @@ -123,7 +123,7 @@ class QNetworkReplyHttpImplPrivate: public QNetworkReplyPrivate { public: - static QHttpNetworkRequest::Priority convert(const QNetworkRequest::Priority& prio); + static QHttpNetworkRequest::Priority convert(QNetworkRequest::Priority prio); QNetworkReplyHttpImplPrivate(); ~QNetworkReplyHttpImplPrivate();