From 1f34a9b27051213bd396fcadc97fddab9ce84a70 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 6 Jun 2024 10:38:52 +0200 Subject: [PATCH] QSharedMemoryLocker: make ctor explicit A QSharedMemory* is not a faithful representation of a QSharedMemoryLocker, so the resp. converting ctor should be explicit. Found in API-review. Pick-to: 6.7 Change-Id: I2267a193868c4d0979f59ed0847a0e4af64ffe76 Reviewed-by: Giuseppe D'Angelo (cherry picked from commit 54a57b1e6a011450bc4549abb98141e2440c3f6a) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/ipc/qsharedmemory_p.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/corelib/ipc/qsharedmemory_p.h b/src/corelib/ipc/qsharedmemory_p.h index 52a94e3c2ae..9ee4c49e6c5 100644 --- a/src/corelib/ipc/qsharedmemory_p.h +++ b/src/corelib/ipc/qsharedmemory_p.h @@ -43,7 +43,8 @@ class QSharedMemoryLocker { Q_DISABLE_COPY(QSharedMemoryLocker) public: - Q_NODISCARD_CTOR QSharedMemoryLocker(QSharedMemory *sharedMemory) : q_sm(sharedMemory) + Q_NODISCARD_CTOR explicit QSharedMemoryLocker(QSharedMemory *sharedMemory) + : q_sm(sharedMemory) { Q_ASSERT(q_sm); }