From 1f129d1589d50d3380b9b3596d3698b5e03068b5 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Tue, 27 Aug 2024 18:56:09 +0200 Subject: [PATCH] QXmlString: add a few missing operations ... namely isNull() and op==/!=(). These will be needed for porting comparesEqual() from public getters to direct data member access, in order to make them earn their noexcept tagging. Change-Id: Id8677d39dc581d03adfd3d0d420907ff60c0423a Reviewed-by: Thiago Macieira (cherry picked from commit e0ae91bd5880d1f8ab36d42cff428bb8246f73c2) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/serialization/qxmlstream.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/corelib/serialization/qxmlstream.h b/src/corelib/serialization/qxmlstream.h index 978088c4a80..d83fab7c8a3 100644 --- a/src/corelib/serialization/qxmlstream.h +++ b/src/corelib/serialization/qxmlstream.h @@ -33,6 +33,14 @@ public: operator QStringView() const noexcept { return QStringView(m_string.data(), m_string.size); } qsizetype size() const noexcept { return m_string.size; } + bool isNull() const noexcept { return m_string.isNull(); } + +private: + friend bool comparesEqual(const QXmlString &lhs, const QXmlString &rhs) noexcept + { + return QStringView(lhs) == QStringView(rhs); + } + Q_DECLARE_EQUALITY_COMPARABLE(QXmlString) }; }