From 1da71e5e7d099b429802da67feb405214afa3b38 Mon Sep 17 00:00:00 2001 From: Christian Ehrlicher Date: Sun, 4 May 2025 15:51:23 +0200 Subject: [PATCH] QHeaderView: fix logic in setOffset() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the logic in setOffset() which was accidentally reversed during fixing of UB during signed overflow. Amends 49fcac99deea390901000a74deea1c0c690b6ae2. Coverity-Id: 479557 Pick-to: 6.8 6.5 Fixes: QTBUG-136362 Fixes: QTBUG-136477 Change-Id: Ifc9c80346355b0a9e516effe2ff8b60b1966d67a Reviewed-by: Thorbjørn Lund Martsum (cherry picked from commit e808b38d4bb894f42b7dfe52f1ef67a0d48c23ff) Reviewed-by: Qt Cherry-pick Bot --- src/widgets/itemviews/qheaderview.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/widgets/itemviews/qheaderview.cpp b/src/widgets/itemviews/qheaderview.cpp index 662e468d3aa..73c448362ac 100644 --- a/src/widgets/itemviews/qheaderview.cpp +++ b/src/widgets/itemviews/qheaderview.cpp @@ -429,7 +429,7 @@ void QHeaderView::setOffset(int newOffset) const int ndelta = q26::saturate_cast(d->headerOffset - qint64{newOffset}); d->headerOffset = newOffset; if (d->orientation == Qt::Horizontal) { - if (isLeftToRight()) { + if (isRightToLeft()) { if (int r; !qMulOverflow<-1>(ndelta, &r)) d->viewport->scroll(r, 0); else