From 1d5c003e0e9eb8c603614f2e408bb9a28712e1c5 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Fri, 5 May 2023 18:20:55 +0200 Subject: [PATCH] rsslisting example: shuffle parts of constructor for clarity Group related things together, improve the logical flow of the code. Task-number: QTBUG-111228 Change-Id: If3eb577b74128b305ca5fb3074168280ec2d4db8 Reviewed-by: Ivan Solovev Reviewed-by: Marc Mutz (cherry picked from commit fb2d4074c18b0a47ee5b65e3145124f92d9fe1df) --- .../corelib/serialization/rsslisting/rsslisting.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/corelib/serialization/rsslisting/rsslisting.cpp b/examples/corelib/serialization/rsslisting/rsslisting.cpp index 2eeb1f0e175..8a82991775e 100644 --- a/examples/corelib/serialization/rsslisting/rsslisting.cpp +++ b/examples/corelib/serialization/rsslisting/rsslisting.cpp @@ -35,11 +35,14 @@ its operation, and also allows very large data sources to be read. RSSListing::RSSListing(const QString &url, QWidget *parent) : QWidget(parent), currentReply(0) { + connect(&manager, &QNetworkAccessManager::finished, this, &RSSListing::finished); lineEdit = new QLineEdit(this); lineEdit->setText(url); + connect(lineEdit, &QLineEdit::returnPressed, this, &RSSListing::fetch); fetchButton = new QPushButton(tr("Fetch"), this); + connect(fetchButton, &QPushButton::clicked, this, &RSSListing::fetch); treeWidget = new QTreeWidget(this); connect(treeWidget, &QTreeWidget::itemActivated, @@ -49,18 +52,11 @@ RSSListing::RSSListing(const QString &url, QWidget *parent) treeWidget->setHeaderLabels(headerLabels); treeWidget->header()->setSectionResizeMode(QHeaderView::ResizeToContents); - connect(&manager, &QNetworkAccessManager::finished, - this, &RSSListing::finished); - - connect(lineEdit, &QLineEdit::returnPressed, this, &RSSListing::fetch); - connect(fetchButton, &QPushButton::clicked, this, &RSSListing::fetch); - - QVBoxLayout *layout = new QVBoxLayout(this); QHBoxLayout *hboxLayout = new QHBoxLayout; - hboxLayout->addWidget(lineEdit); hboxLayout->addWidget(fetchButton); + QVBoxLayout *layout = new QVBoxLayout(this); layout->addLayout(hboxLayout); layout->addWidget(treeWidget);