From 1a836a2abda6af2b5b0e85816ca9671528fcce85 Mon Sep 17 00:00:00 2001 From: Mikolaj Boc Date: Thu, 14 Jul 2022 16:06:40 +0200 Subject: [PATCH] Fix losing grip on dragged window on WASM MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a window is being dragged, we should not check for the target window's resizability in QWasmCompositor::processMouse as: 1) the target window under the cursor might be different from the dragged window when the pointer is moving quickly 2) we have checked that already when qualifying the window for dragging when handling EMSCRIPTEN_EVENT_MOUSEDOWN at line 1022 Therefore, the condition for target window's resizability has been removed. Change-Id: Ib999d213f1e0a770fa76324fc7bf44c6d4ab806a Reviewed-by: David Skoland Reviewed-by: Lorn Potter (cherry picked from commit a7e187cf1631e0f5434c09c4c398a7c4ef138593) Reviewed-by: Morten Johan Sørvig --- src/plugins/platforms/wasm/qwasmcompositor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/platforms/wasm/qwasmcompositor.cpp b/src/plugins/platforms/wasm/qwasmcompositor.cpp index 920a8bf016c..45e9eeeeddb 100644 --- a/src/plugins/platforms/wasm/qwasmcompositor.cpp +++ b/src/plugins/platforms/wasm/qwasmcompositor.cpp @@ -1073,7 +1073,7 @@ bool QWasmCompositor::processMouse(int eventType, const EmscriptenMouseEvent *mo } } - if (m_windowBeingManipulated && isTargetWindowResizable) { + if (m_windowBeingManipulated) { if (m_resizeMode == QWasmCompositor::ResizeNone) { m_windowBeingManipulated->setPosition( m_windowBeingManipulated->position() + QPoint(mouseEvent->movementX, mouseEvent->movementY));