From 18ecd62aaa12217ba6beb2178b38ef471ea538ec Mon Sep 17 00:00:00 2001 From: Mate Barany Date: Wed, 21 Sep 2022 17:23:07 +0200 Subject: [PATCH] windeployqt: Use default constructor of QString and then append Addressing a comment from the review of QTBUG-98434. Instead of assigning an initial value to the QString, create an empty QString first and then append to the QString. Task-number: QTBUG-103100 Change-Id: I8f2569ac2a2203e6459bbc7df789c9ef34f598d0 Reviewed-by: Marc Mutz --- src/tools/windeployqt/main.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tools/windeployqt/main.cpp b/src/tools/windeployqt/main.cpp index d1d1fb6b5f3..ecd25ab81da 100644 --- a/src/tools/windeployqt/main.cpp +++ b/src/tools/windeployqt/main.cpp @@ -669,7 +669,8 @@ static inline QString helpText(const QCommandLineParser &p) const qsizetype argumentsStart = result.lastIndexOf("\nArguments:"_L1); if (moduleStart >= argumentsStart) return result; - QString moduleHelp = + QString moduleHelp; + moduleHelp += "\n\nQt libraries can be added by passing their name (-xml) or removed by passing\n" "the name prepended by --no- (--no-xml). Available libraries:\n"_L1; moduleHelp += lineBreak(QString::fromLatin1(formatQtModules(0xFFFFFFFFFFFFFFFFull, true)));