From 18552d0c62166fcdab72ac94962d5ed8577d3d5d Mon Sep 17 00:00:00 2001 From: Lorn Potter Date: Mon, 26 May 2025 11:24:50 +1000 Subject: [PATCH] wasm: Make sure native fetch is destroyed before reply is canceled, closed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit finished signal was being sent before native fetch was destroyed which, in some instances, was causing a crash. Fixes: QTBUG-136710 Change-Id: I2134431cbf9af0511d888dc5db3f589f5259c88a Reviewed-by: Piotr WierciƄski Reviewed-by: Even Oscar Andersen (cherry picked from commit f5d888b44a5d418a601d8d7920dc5826617f9e90) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qnetworkreplywasmimpl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/network/access/qnetworkreplywasmimpl.cpp b/src/network/access/qnetworkreplywasmimpl.cpp index b17c3b2cc42..2ba21642add 100644 --- a/src/network/access/qnetworkreplywasmimpl.cpp +++ b/src/network/access/qnetworkreplywasmimpl.cpp @@ -127,13 +127,13 @@ void QNetworkReplyWasmImpl::close() { Q_D(QNetworkReplyWasmImpl); + emscripten_fetch_close(d->m_fetch); if (d->state != QNetworkReplyPrivate::Aborted && d->state != QNetworkReplyPrivate::Finished && d->state != QNetworkReplyPrivate::Idle) { d->state = QNetworkReplyPrivate::Finished; d->setCanceled(); } - emscripten_fetch_close(d->m_fetch); QNetworkReply::close(); }