1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QString: use equalStrings in operator== and operator!=

Browse Source 
QStringView already did since 6.0. I don't know how we missed this.

Change-Id: I5acc02341c5940499682fffd1774f7c3a807317a
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 3c4c7860f08e45de2965ea544a8eb742549bb150)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Thiago Macieira 2023-07-24 18:22:59 -07:00 committed by Qt Cherry-pick Bot
parent cbea2f5705
commit 16cce399d2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/corelib/text/qstring.h
View File

@ -692,7 +692,7 @@ public:
static QString number(double, char format='g', int precision=6);
friend bool operator==(const QString &s1, const QString &s2) noexcept
{ return (s1.size() == s2.size()) && QtPrivate::compareStrings(s1, s2, Qt::CaseSensitive) == 0; }
{ return (s1.size() == s2.size()) && QtPrivate::equalStrings(s1, s2); }
friend bool operator< (const QString &s1, const QString &s2) noexcept
{ return QtPrivate::compareStrings(s1, s2, Qt::CaseSensitive) < 0; }
friend bool operator> (const QString &s1, const QString &s2) noexcept { return s2 < s1; }
@ -701,7 +701,7 @@ public:
friend bool operator>=(const QString &s1, const QString &s2) noexcept { return !(s1 < s2); }
friend bool operator==(const QString &s1, QLatin1StringView s2) noexcept
{ return (s1.size() == s2.size()) && QtPrivate::compareStrings(s1, s2, Qt::CaseSensitive) == 0; }
{ return (s1.size() == s2.size()) && QtPrivate::equalStrings(s1, s2); }
friend bool operator< (const QString &s1, QLatin1StringView s2) noexcept
{ return QtPrivate::compareStrings(s1, s2, Qt::CaseSensitive) < 0; }
friend bool operator> (const QString &s1, QLatin1StringView s2) noexcept