1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Examples: "About &Qt" should show info about Qt, not quit

Browse Source 
A few examples seem to have copied and pasted a help action "About
&Qt" that triggered QCoreApplication::quit. This does not look like
best practice. Use QApplication::aboutQt instead.

Task-number: QTBUG-111228
Change-Id: I1887a3c999d752a24c7c4d3cabc4a5d63b29b966
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
(cherry picked from commit 3ccf2f8308ba33cab575c22ad2e246b987a3dc0c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Edward Welbourne 2023-06-14 16:18:32 +02:00
parent e57bf5b99d
commit 1671172375
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/corelib/serialization/streambookmarks/mainwindow.cpp
View File

@ -148,6 +148,6 @@ void MainWindow::createMenus()
QMenu *helpMenu = menuBar()->addMenu(tr("&Help")); QMenu *helpMenu = menuBar()->addMenu(tr("&Help"));
helpMenu->addAction(tr("&About"), this, &MainWindow::about); helpMenu->addAction(tr("&About"), this, &MainWindow::about);
helpMenu->addAction(tr("About &Qt"), qApp, &QCoreApplication::quit); helpMenu->addAction(tr("About &Qt"), qApp, &QApplication::aboutQt);
} }
//! [5] //! [5]

2
examples/widgets/tools/settingseditor/mainwindow.cpp
View File

@ -151,7 +151,7 @@ void MainWindow::createActions()
QMenu *helpMenu = menuBar()->addMenu(tr("&Help")); QMenu *helpMenu = menuBar()->addMenu(tr("&Help"));
helpMenu->addAction(tr("&About"), this, &MainWindow::about); helpMenu->addAction(tr("&About"), this, &MainWindow::about);
helpMenu->addAction(tr("About &Qt"), qApp, &QCoreApplication::quit); helpMenu->addAction(tr("About &Qt"), qApp, &QApplication::aboutQt);
} }
void MainWindow::setSettingsObject(const SettingsPtr &settings) void MainWindow::setSettingsObject(const SettingsPtr &settings)

2
examples/xml/dombookmarks/mainwindow.cpp
View File

@ -106,6 +106,6 @@ void MainWindow::createMenus()
QMenu *helpMenu = menuBar()->addMenu(tr("&Help")); QMenu *helpMenu = menuBar()->addMenu(tr("&Help"));
helpMenu->addAction(tr("&About"), this, &MainWindow::about); helpMenu->addAction(tr("&About"), this, &MainWindow::about);
helpMenu->addAction(tr("About &Qt"), qApp, &QCoreApplication::quit); helpMenu->addAction(tr("About &Qt"), qApp, &QApplication::aboutQt);
} }
//! [4] //! [4]