From 131c7009fa4b3969bb74b17f8e2cec8ba6e710a8 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Thu, 17 Mar 2022 15:33:07 +0100 Subject: [PATCH] Fix char/uchar comparison warning in toPercentEncoding This amends commit 5291dc7dcfa489354d3f880468902debf755d9cd Change-Id: Icdd9562f74a4de0323ba8fef558958af41eeb5a1 Reviewed-by: Thiago Macieira --- src/corelib/text/qbytearray.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/text/qbytearray.cpp b/src/corelib/text/qbytearray.cpp index a261406f389..88aef5989fd 100644 --- a/src/corelib/text/qbytearray.cpp +++ b/src/corelib/text/qbytearray.cpp @@ -4604,7 +4604,7 @@ QByteArray QByteArray::toPercentEncoding(const QByteArray &exclude, const QByteA qsizetype length = 0; for (unsigned char c : *this) { - if (c != percent + if (char(c) != percent && ((c >= 0x61 && c <= 0x7A) // ALPHA || (c >= 0x41 && c <= 0x5A) // ALPHA || (c >= 0x30 && c <= 0x39) // DIGIT