From 12b1ec4b309ffe43cb89e2fe06835d0b04bdffb6 Mon Sep 17 00:00:00 2001 From: Axel Spoerl Date: Tue, 14 Jun 2022 10:06:34 +0200 Subject: [PATCH] xcb: Replace qCWarning by qCDebug in QXcbConnection::printXcbError() Example: Error "BadWindow" (3) is raised by the XCB backend when a mouse event is processed on a resource that disappears between posting and processing of the event. That constellation is harmless and can occur in async environments. As XCB errors point to coding issues, this patch changes their logging behavior from qCWarning to qCDebug. Fixes: QTBUG-56893 Change-Id: Idee5ee80efaf9cd6686448779f76c68d5e4c9b63 Reviewed-by: Liang Qi (cherry picked from commit 373392eeb4199654e954f70ce919850f090d59bd) Reviewed-by: Qt Cherry-pick Bot --- src/plugins/platforms/xcb/qxcbconnection.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/plugins/platforms/xcb/qxcbconnection.cpp b/src/plugins/platforms/xcb/qxcbconnection.cpp index cf2a2af457a..51530e00553 100644 --- a/src/plugins/platforms/xcb/qxcbconnection.cpp +++ b/src/plugins/platforms/xcb/qxcbconnection.cpp @@ -449,12 +449,12 @@ void QXcbConnection::printXcbError(const char *message, xcb_generic_error_t *err uint clamped_error_code = qMin(error->error_code, (sizeof(xcb_errors) / sizeof(xcb_errors[0])) - 1); uint clamped_major_code = qMin(error->major_code, (sizeof(xcb_protocol_request_codes) / sizeof(xcb_protocol_request_codes[0])) - 1); - qCWarning(lcQpaXcb, "%s: %d (%s), sequence: %d, resource id: %d, major code: %d (%s), minor code: %d", - message, - int(error->error_code), xcb_errors[clamped_error_code], - int(error->sequence), int(error->resource_id), - int(error->major_code), xcb_protocol_request_codes[clamped_major_code], - int(error->minor_code)); + qCDebug(lcQpaXcb, "%s: %d (%s), sequence: %d, resource id: %d, major code: %d (%s), minor code: %d", + message, + int(error->error_code), xcb_errors[clamped_error_code], + int(error->sequence), int(error->resource_id), + int(error->major_code), xcb_protocol_request_codes[clamped_major_code], + int(error->minor_code)); } static Qt::MouseButtons translateMouseButtons(int s)