1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prefer QString(count, character) over QString::fill()ing

Browse Source 
It lets the string be const, if nothing else.

Change-Id: Iffc1cfe71c5f6030b3f7434f964f2f2c102bf9c0
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
This commit is contained in:
Edward Welbourne 2022-02-08 14:52:13 +01:00
parent ed0657b5e1
commit 1013cf49c7
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
View File

@ -814,8 +814,7 @@ void tst_QSqlQuery::oraClob()
QCOMPARE( q.value( 1 ).toString(), QString( "lala" ) ); QCOMPARE( q.value( 1 ).toString(), QString( "lala" ) );
// loooong string // loooong string
QString loong; const QString loong(25000, QLatin1Char('A'));
loong.fill( QLatin1Char( 'A' ), 25000 );
QVERIFY_SQL( q, prepare( "insert into " + clobby + " (id, cl, bl) values(?, ?, ?)" ) ); QVERIFY_SQL( q, prepare( "insert into " + clobby + " (id, cl, bl) values(?, ?, ?)" ) );
q.addBindValue( 3 ); q.addBindValue( 3 );
q.addBindValue( loong, QSql::Binary ); q.addBindValue( loong, QSql::Binary );
@ -2549,9 +2548,7 @@ void tst_QSqlQuery::sqlServerLongStrings()
QVERIFY_SQL( q, exec() ); QVERIFY_SQL( q, exec() );
QString testStr; const QString testStr(85000, QLatin1Char('a'));
testStr.fill( QLatin1Char( 'a' ), 85000 );
q.addBindValue( 1 ); q.addBindValue( 1 );
@ -3609,7 +3606,6 @@ void tst_QSqlQuery::task_217003()
void tst_QSqlQuery::task_250026() void tst_QSqlQuery::task_250026()
{ {
QString data258, data1026;
QFETCH( QString, dbName ); QFETCH( QString, dbName );
QSqlDatabase db = QSqlDatabase::database( dbName ); QSqlDatabase db = QSqlDatabase::database( dbName );
CHECK_DATABASE( db ); CHECK_DATABASE( db );
@ -3622,8 +3618,8 @@ void tst_QSqlQuery::task_250026()
QSKIP( "Db doesn't support \"1100\" as a size for fields"); QSKIP( "Db doesn't support \"1100\" as a size for fields");
} }
data258.fill( 'A', 258 ); const QString data258(258, QLatin1Char('A'));
data1026.fill( 'A', 1026 ); const QString data1026(1026, QLatin1Char('A'));
QVERIFY_SQL( q, prepare( "insert into " + tableName + "(longfield) VALUES (:longfield)" ) ); QVERIFY_SQL( q, prepare( "insert into " + tableName + "(longfield) VALUES (:longfield)" ) );
q.bindValue( ":longfield", data258 ); q.bindValue( ":longfield", data258 );
QVERIFY_SQL( q, exec() ); QVERIFY_SQL( q, exec() );