1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SQL/MySQL: honor schema when retrieving table record

Browse Source 
Honor the schema when retrieving the table record - otherwise we might
end up getting the data for the wrong table (same tablename but wrong
schema).

Fixes: QTBUG-127129
Task-number: QTBUG-122723
Change-Id: Ia3e9293dbdc77da760dd4d0702104048187fad5f
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 920dfb2f443042777ea9547ff7a8beef56e90d92)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Christian Ehrlicher 2024-07-17 19:59:59 +02:00 committed by Qt Cherry-pick Bot
parent 49193d4afd
commit 0ff64a5b99
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/sqldrivers/mysql/qsql_mysql.cpp
View File

@ -1508,7 +1508,8 @@ QSqlRecord QMYSQLDriver::record(const QString &tablename) const
return r; return r;
// no binding of WHERE possible with MySQL // no binding of WHERE possible with MySQL
// escaping on WHERE clause does not work, so use mysql_real_escape_string() // escaping on WHERE clause does not work, so use mysql_real_escape_string()
stmt = "SELECT column_name, column_default FROM information_schema.columns WHERE table_name = '%1'"_L1; stmt = "SELECT column_name, column_default FROM information_schema.columns WHERE table_schema = '"_L1
+ d->dbName + "' AND table_name = '%1'"_L1;
const auto baTableName = tablename.toUtf8(); const auto baTableName = tablename.toUtf8();
QVarLengthArray<char> tableNameQuoted(baTableName.size() * 2 + 1); QVarLengthArray<char> tableNameQuoted(baTableName.size() * 2 + 1);
#if defined(MARIADB_VERSION_ID) #if defined(MARIADB_VERSION_ID)