1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Windows: Fix potential crash when retrieving default printer

Browse Source 
GetDefaultPrinter() has been observed to return size == 0.

Pick-to: 6.3 6.2 5.15
Fixes: QTBUG-53290
Change-Id: Id4c7a06d14d368c792e15e55cacf2366b6aedc7b
Reviewed-by: Andy Shaw <andy.shaw@qt.io>
This commit is contained in:
Friedemann Kleint 2022-03-25 18:03:19 +01:00
parent d85c6527b5
commit 0cdb44f01f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/printsupport/platform/windows/qwindowsprintdevice.cpp
View File

@ -499,7 +499,7 @@ QStringList QWindowsPrintDevice::availablePrintDeviceIds()
QString QWindowsPrintDevice::defaultPrintDeviceId() QString QWindowsPrintDevice::defaultPrintDeviceId()
{ {
DWORD size = 0; DWORD size = 0;
if (GetDefaultPrinter(nullptr, &size) == ERROR_FILE_NOT_FOUND) if (GetDefaultPrinter(nullptr, &size) == ERROR_FILE_NOT_FOUND || size < 2)
return QString(); return QString();
QScopedArrayPointer<wchar_t> name(new wchar_t[size]); QScopedArrayPointer<wchar_t> name(new wchar_t[size]);