From 0c343c4c85b5ca31723aeb97821976fc01275186 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 20 Mar 2024 18:43:56 +0100 Subject: [PATCH] QSignalSpy::appendArgs(): move-append the QVariantList Using the rvalue overload of append() is more efficient, since we skip the alias check and the appendee's atomic ref-count ping-pong inside lvalue append(). Task-number: QTBUG-123544 Change-Id: Ia76fdf28cba13d524fbbe894658a86a45a1ebe79 Reviewed-by: David Faure (cherry picked from commit d5d2688acb5b67b41149db3332fa9bad11b39808) Reviewed-by: Qt Cherry-pick Bot --- src/testlib/qsignalspy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testlib/qsignalspy.h b/src/testlib/qsignalspy.h index a60ae05e18e..ef1c71b5c67 100644 --- a/src/testlib/qsignalspy.h +++ b/src/testlib/qsignalspy.h @@ -200,7 +200,7 @@ private: else list << QVariant(QMetaType(type), a[i + 1]); } - append(list); + append(std::move(list)); if (m_waiting) { locker.unlock();