1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove spurious and unused QUtcTZP::init() with too few arguments

Browse Source 
QUtcTimeZonePrivate accommodates the custom time-zone API and, as
such, needs to know all of its details when constructed. The
constructor as a plain UTC-offset constructs the details to match a
custom zone, so that it also has those details initialized. As a
result, this backend never initialized a zone from only its IANA ID,
as all the others do, so does not need an init() with that signature
(which did not adequately initialize the instance anyway).

Change-Id: I462f537c9d48e09f05f91aae0ff6c7a317b421c1
Reviewed-by: Mate Barany <mate.barany@qt.io>
Reviewed-by: Magdalena Stojek <magdalena.stojek@qt.io>
(cherry picked from commit 70b680502997678b7c9964acef6569b18b6a65bf)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Edward Welbourne 2024-08-28 11:29:30 +02:00 committed by Qt Cherry-pick Bot
parent d563ec3fba
commit 0b89eb6c6f
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/corelib/time/qtimezoneprivate.cpp
View File

@ -1012,11 +1012,6 @@ bool QUtcTimeZonePrivate::isDataLocale(const QLocale &locale) const
return locale.language() == QLocale::C || locale.language() == QLocale::English;
}
void QUtcTimeZonePrivate::init(const QByteArray &zoneId)
{
m_id = zoneId;
}
void QUtcTimeZonePrivate::init(const QByteArray &zoneId, int offsetSeconds, const QString &name,
const QString &abbreviation, QLocale::Territory territory,
const QString &comment)

1
src/corelib/time/qtimezoneprivate_p.h
View File

@ -218,7 +218,6 @@ public:
void serialize(QDataStream &ds) const override;
private:
void init(const QByteArray &zoneId);
void init(const QByteArray &zoneId, int offsetSeconds, const QString &name,
const QString &abbreviation, QLocale::Territory territory,
const QString &comment);