QAbstractFileEngine: make setFileTime not a pure virtual

Most engines just had to override the virtual to return false. So do it
in the base class.

Change-Id: I8d96dea9955d4c749b99fffd14cd738a48aa818c
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
This commit is contained in:
Thiago Macieira 2017-07-02 00:41:28 -07:00
parent 1b73c202ce
commit 0b7d9d2811
9 changed files with 9 additions and 35 deletions

View File

@ -726,10 +726,10 @@ QString QAbstractFileEngine::owner(FileOwner owner) const
return QString();
}
/*!
\fn bool QAbstractFileEngine::setFileTime(const QDateTime &newDate, FileTime time)
/*!
\since 5.10
Sets the file \a time to \a newDate, returning true if successful;
otherwise returns false.
@ -737,6 +737,12 @@ QString QAbstractFileEngine::owner(FileOwner owner) const
\sa fileTime()
*/
bool QAbstractFileEngine::setFileTime(const QDateTime &newDate, FileTime time)
{
Q_UNUSED(newDate);
Q_UNUSED(time);
return false;
}
/*!
If \a time is \c CreationTime, return when the file was created.

View File

@ -144,7 +144,7 @@ public:
virtual QString fileName(FileName file=DefaultName) const;
virtual uint ownerId(FileOwner) const;
virtual QString owner(FileOwner) const;
virtual bool setFileTime(const QDateTime &newDate, FileTime time) = 0;
virtual bool setFileTime(const QDateTime &newDate, FileTime time);
virtual QDateTime fileTime(FileTime time) const;
virtual void setFileName(const QString &file);
virtual int handle() const;

View File

@ -1457,13 +1457,6 @@ QString QResourceFileEngine::owner(FileOwner) const
return QString();
}
bool QResourceFileEngine::setFileTime(const QDateTime &newDate, FileTime time)
{
Q_UNUSED(newDate);
Q_UNUSED(time);
return false;
}
QDateTime QResourceFileEngine::fileTime(FileTime time) const
{
Q_D(const QResourceFileEngine);

View File

@ -103,7 +103,6 @@ public:
virtual uint ownerId(FileOwner) const Q_DECL_OVERRIDE;
virtual QString owner(FileOwner) const Q_DECL_OVERRIDE;
virtual bool setFileTime(const QDateTime &newDate, FileTime time) Q_DECL_OVERRIDE;
virtual QDateTime fileTime(FileTime time) const Q_DECL_OVERRIDE;
virtual Iterator *beginEntryList(QDir::Filters filters, const QStringList &filterNames) Q_DECL_OVERRIDE;

View File

@ -206,13 +206,6 @@ public:
return type & flags;
}
bool setFileTime(const QDateTime &newDate, FileTime time) override
{
Q_UNUSED(newDate);
Q_UNUSED(time);
return false;
}
QString fileName(FileName file = DefaultName) const override
{
int pos;

View File

@ -61,7 +61,6 @@ public:
qint64 read(char *data, qint64 maxlen) override;
qint64 pos() const override;
bool seek(qint64 pos) override;
bool setFileTime(const QDateTime &newDate, FileTime time) override;
QString fileName(FileName file) const override;
void setFileName(const QString &file) override;
QStringList entryList(QDir::Filters filters, const QStringList &filterNames) const override;

View File

@ -435,13 +435,6 @@ bool QIOSFileEngineAssetsLibrary::seek(qint64 pos)
return true;
}
bool QIOSFileEngineAssetsLibrary::setFileTime(const QDateTime &newDate, FileTime time)
{
Q_UNUSED(newDate);
Q_UNUSED(time);
return false;
}
QString QIOSFileEngineAssetsLibrary::fileName(FileName file) const
{
Q_UNUSED(file);

View File

@ -440,14 +440,6 @@ QDateTime QWinRTFileEngine::fileTime(FileTime type) const
return QDateTime(date, time);
}
bool QWinRTFileEngine::setFileTime(const QDateTime &newDate, FileTime time)
{
Q_UNUSED(newDate);
Q_UNUSED(time);
Q_UNIMPLEMENTED();
return false;
}
qint64 QWinRTFileEngine::read(char *data, qint64 maxlen)
{
Q_D(QWinRTFileEngine);

View File

@ -89,7 +89,6 @@ public:
bool setPermissions(uint perms) override;
QString fileName(FileName type=DefaultName) const override;
QDateTime fileTime(FileTime type) const override;
bool setFileTime(const QDateTime &newDate, FileTime time) override;
qint64 read(char *data, qint64 maxlen) override;
qint64 write(const char *data, qint64 len) override;