From 0b1d950e437bd0e112b7f4f25b42f3318634200a Mon Sep 17 00:00:00 2001
From: Inho Lee <inho.lee@qt.io>
Date: Wed, 19 Jun 2024 13:14:14 +0200
Subject: [PATCH] TextInputV3: Prevent a recursive update call
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

While scrollEvent,
Qt calls textinput' update with cursorRect
and anchorRect. In that case,
TextInputV3's update function can make
another update calls with saved data from
compositor.
So, commit will be skipped for cursorRect
and anchorRect.

Fixes: QTBUG-126275
Pick-to: 6.8 6.7
Change-Id: I9c47c46b20a227e72488e3b9bac3d6fc5e4b9066
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
Reviewed-by: Robert Löhning <robert.loehning@qt.io>
---
 src/plugins/platforms/wayland/qwaylandtextinputv3.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/plugins/platforms/wayland/qwaylandtextinputv3.cpp b/src/plugins/platforms/wayland/qwaylandtextinputv3.cpp
index bb449c9d60d..a4ff7100649 100644
--- a/src/plugins/platforms/wayland/qwaylandtextinputv3.cpp
+++ b/src/plugins/platforms/wayland/qwaylandtextinputv3.cpp
@@ -238,7 +238,6 @@ void QWaylandTextInputv3::updateState(Qt::InputMethodQueries queries, uint32_t f
         if (surfaceRect != m_cursorRect) {
             set_cursor_rectangle(surfaceRect.x(), surfaceRect.y(), surfaceRect.width(), surfaceRect.height());
             m_cursorRect = surfaceRect;
-            needsCommit = true;
         }
     }