From 0ae162e2a9c49af66ab519a48b930c7566431d25 Mon Sep 17 00:00:00 2001
From: Marc Mutz <marc.mutz@qt.io>
Date: Mon, 2 Sep 2024 11:01:19 +0200
Subject: [PATCH] QPdfWriter: pass QUuid by value
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

QUuid is a) trivially copyable, b) ≤ 16 bytes, so as per [1] should be
passed by value. Clazy, indeed, complains, so fix it.

Found in API-review.

Amends 2fbece8a73cb2d2692c78c38e1576c0c9c62fce7.

[1] https://www.macieira.org/blog/2012/02/the-value-of-passing-by-value/

Change-Id: I321ebd650dac8e58c173d957259c3700b1f59ace
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 7550f0e2c1a4ca10a0e4604e2d429b98481d4e2d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/gui/painting/qpdfwriter.cpp | 2 +-
 src/gui/painting/qpdfwriter.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gui/painting/qpdfwriter.cpp b/src/gui/painting/qpdfwriter.cpp
index be4b73aa640..c5b3226cf30 100644
--- a/src/gui/painting/qpdfwriter.cpp
+++ b/src/gui/painting/qpdfwriter.cpp
@@ -205,7 +205,7 @@ QUuid QPdfWriter::documentId() const
   \since 6.8
   Sets the ID of the document to \a documentId.
   */
-void QPdfWriter::setDocumentId(const QUuid &documentId)
+void QPdfWriter::setDocumentId(QUuid documentId)
 {
     Q_D(QPdfWriter);
     d->engine->d_func()->documentId = documentId;
diff --git a/src/gui/painting/qpdfwriter.h b/src/gui/painting/qpdfwriter.h
index 2938f5c1cf0..042344ff5d7 100644
--- a/src/gui/painting/qpdfwriter.h
+++ b/src/gui/painting/qpdfwriter.h
@@ -37,7 +37,7 @@ public:
     void setCreator(const QString &creator);
 
     QUuid documentId() const;
-    void setDocumentId(const QUuid &documentId);
+    void setDocumentId(QUuid documentId);
 
     bool newPage() override;