1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Q*PaintEngineState: use canonical signature for the copy constructor

Browse Source 
I'm not sure why this code had copy constructors taking by non-const
reference. Add the missing const.

Change-Id: Ie6d1cb6eab7b829a59e21f1874b041a00a52d1e9
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
This commit is contained in:
Giuseppe D'Angelo 2025-01-08 16:47:26 +01:00
parent c64774eef7
commit 09e40152f8
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/painting/qpaintengine_raster.cpp
View File

@ -515,7 +515,7 @@ QRasterPaintEngineState::QRasterPaintEngineState()
dirty = 0; dirty = 0;
} }
QRasterPaintEngineState::QRasterPaintEngineState(QRasterPaintEngineState &s) QRasterPaintEngineState::QRasterPaintEngineState(const QRasterPaintEngineState &s)
: QPainterState(s) : QPainterState(s)
, lastPen(s.lastPen) , lastPen(s.lastPen)
, penData(s.penData) , penData(s.penData)

2
src/gui/painting/qpaintengine_raster_p.h
View File

@ -39,7 +39,7 @@ class QClipData;
class QRasterPaintEngineState : public QPainterState class QRasterPaintEngineState : public QPainterState
{ {
public: public:
QRasterPaintEngineState(QRasterPaintEngineState &other); QRasterPaintEngineState(const QRasterPaintEngineState &other);
QRasterPaintEngineState(); QRasterPaintEngineState();
~QRasterPaintEngineState(); ~QRasterPaintEngineState();

2
src/opengl/qopenglpaintengine.cpp
View File

@ -2680,7 +2680,7 @@ QPainterState *QOpenGL2PaintEngineEx::createState(QPainterState *orig) const
return s; return s;
} }
QOpenGL2PaintEngineState::QOpenGL2PaintEngineState(QOpenGL2PaintEngineState &other) QOpenGL2PaintEngineState::QOpenGL2PaintEngineState(const QOpenGL2PaintEngineState &other)
: QPainterState(other) : QPainterState(other)
{ {
isNew = true; isNew = true;

2
src/opengl/qopenglpaintengine_p.h
View File

@ -54,7 +54,7 @@ class QOpenGL2PaintEngineExPrivate;
class QOpenGL2PaintEngineState : public QPainterState class QOpenGL2PaintEngineState : public QPainterState
{ {
public: public:
QOpenGL2PaintEngineState(QOpenGL2PaintEngineState &other); QOpenGL2PaintEngineState(const QOpenGL2PaintEngineState &other);
QOpenGL2PaintEngineState(); QOpenGL2PaintEngineState();
~QOpenGL2PaintEngineState(); ~QOpenGL2PaintEngineState();