From 090b66acf34420536c4a5f3e5313dfcb525d74f6 Mon Sep 17 00:00:00 2001 From: Assam Boudjelthia Date: Thu, 2 Jan 2025 17:29:38 +0200 Subject: [PATCH] Android: extract QtSurface.getHolder() to a var and re-use it Change-Id: If0dfc66a3905640c6074f74849bcfca923c06ba5 Reviewed-by: Petri Virkkunen --- .../jar/src/org/qtproject/qt/android/QtSurface.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/android/jar/src/org/qtproject/qt/android/QtSurface.java b/src/android/jar/src/org/qtproject/qt/android/QtSurface.java index c65c57c7113..54474c9f3d0 100644 --- a/src/android/jar/src/org/qtproject/qt/android/QtSurface.java +++ b/src/android/jar/src/org/qtproject/qt/android/QtSurface.java @@ -22,11 +22,9 @@ class QtSurface extends SurfaceView implements SurfaceHolder.Callback setFocusableInTouchMode(false); setZOrderMediaOverlay(onTop); m_surfaceCallback = surfaceCallback; - getHolder().addCallback(this); - if (imageDepth == 16) - getHolder().setFormat(PixelFormat.RGB_565); - else - getHolder().setFormat(PixelFormat.RGBA_8888); + SurfaceHolder holder = getHolder(); + holder.setFormat(imageDepth == 16 ? PixelFormat.RGB_565 : PixelFormat.RGBA_8888); + holder.addCallback(this); } @Override