From 08dd6dce630ceb81f6021216437f01fdc40d120a Mon Sep 17 00:00:00 2001 From: Friedemann Kleint Date: Wed, 13 Sep 2023 10:06:45 +0200 Subject: [PATCH] Add Python-specific note to QOpenGLContext::aboutToBeDestroyed() documentation The signal is not received when emitted from the destructor. Pick-to: 6.5 Fixes: PYSIDE-2460 Change-Id: Ic2273c5b9ef1f53bd58615b6982016e646aee326 Reviewed-by: Adrian Herrmann Reviewed-by: Laszlo Agocs (cherry picked from commit 98e0600c5a317bec17740aa010a36589adc7eab4) Reviewed-by: Qt Cherry-pick Bot --- src/gui/kernel/qopenglcontext.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gui/kernel/qopenglcontext.cpp b/src/gui/kernel/qopenglcontext.cpp index 1dab68e5790..d8da482ecc3 100644 --- a/src/gui/kernel/qopenglcontext.cpp +++ b/src/gui/kernel/qopenglcontext.cpp @@ -452,6 +452,11 @@ void QOpenGLContext::destroy() If you wish to make the context current in order to do clean-up, make sure to only connect to the signal using a direct connection. + + \note In Qt for Python, this signal will not be received when emitted + from the destructor of QOpenGLWidget or QOpenGLWindow due to the Python + instance already being destroyed. We recommend doing cleanups + in QWidget::hideEvent() instead. */ /*!