1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qdbusxmlgenerator.cpp: reduce allocations in typeNameToXml()

Browse Source 
Don't create QString from QL1S, just iterate over QL1S directly.

Change-Id: I35196991224c206841efb11894a9baf736ead97e
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Anton Kudryavtsev 2016-08-22 16:37:31 +03:00
parent d314819fc0
commit 057793a841
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/dbus/qdbusxmlgenerator.cpp
View File

@ -59,10 +59,10 @@ static inline QString typeNameToXml(const char *typeName)
{ {
// ### copied from qtextdocument.cpp // ### copied from qtextdocument.cpp
// ### move this into Qt Core at some point // ### move this into Qt Core at some point
QString plain = QLatin1String(typeName); const QLatin1String plain(typeName);
QString rich; QString rich;
rich.reserve(int(plain.length() * 1.1)); rich.reserve(int(plain.size() * 1.1));
for (int i = 0; i < plain.length(); ++i) { for (int i = 0; i < plain.size(); ++i) {
if (plain.at(i) == QLatin1Char('<')) if (plain.at(i) == QLatin1Char('<'))
rich += QLatin1String("&lt;"); rich += QLatin1String("&lt;");
else if (plain.at(i) == QLatin1Char('>')) else if (plain.at(i) == QLatin1Char('>'))