From 04f3381f11e83d04e7b41f62fe02f5416c863837 Mon Sep 17 00:00:00 2001 From: Wang Yu Date: Fri, 16 Aug 2024 10:20:40 +0800 Subject: [PATCH] Fix the crash of test case authentication required MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Empty transfer is caused by using its password, resulting in a crash Pick-to: 6.5 Change-Id: I2b208ce48b5abc2adea3278d875f3005cda77a8b Reviewed-by: Mårten Nordheim (cherry picked from commit 8143e85bb4706799f9275c25b2caf72b22b457a4) Reviewed-by: Qt Cherry-pick Bot --- tests/manual/qnetworkaccessmanager/qget/downloadmanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/manual/qnetworkaccessmanager/qget/downloadmanager.cpp b/tests/manual/qnetworkaccessmanager/qget/downloadmanager.cpp index b9ad330e1ee..377ac6bcadf 100644 --- a/tests/manual/qnetworkaccessmanager/qget/downloadmanager.cpp +++ b/tests/manual/qnetworkaccessmanager/qget/downloadmanager.cpp @@ -82,7 +82,7 @@ void DownloadManager::authenticationRequired(QNetworkReply *reply, QAuthenticato qDebug() << "authenticationRequired" << reply; TransferItem *transfer = findTransfer(reply); //provide the credentials exactly once, so that it fails if credentials are incorrect. - if ((transfer && !transfer->user.isEmpty()) || !transfer->password.isEmpty()) { + if (transfer && (!transfer->user.isEmpty() || !transfer->password.isEmpty())) { auth->setUser(transfer->user); auth->setPassword(transfer->password); transfer->user.clear();