1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qprocess: don't leak pid pipe if redirection fails in startDetached()

Browse Source 
Change-Id: Ifc42f634964b9412f73f53fb20bd220fcbd9a86c
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Oswald Buddenhagen 2018-05-04 14:05:31 +02:00
parent fc9378952b
commit 04ebb981ab
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/io/qprocess_unix.cpp
View File

@ -925,6 +925,8 @@ bool QProcessPrivate::startDetached(qint64 *pid)
closeChannel(&stdinChannel); closeChannel(&stdinChannel);
closeChannel(&stdoutChannel); closeChannel(&stdoutChannel);
closeChannel(&stderrChannel); closeChannel(&stderrChannel);
qt_safe_close(pidPipe[0]);
qt_safe_close(pidPipe[1]);
qt_safe_close(startedPipe[0]); qt_safe_close(startedPipe[0]);
qt_safe_close(startedPipe[1]); qt_safe_close(startedPipe[1]);
return false; return false;